INT-544 handle bad response issue when adding query to a job#4
Open
pgupta-jw wants to merge 2 commits into
Open
INT-544 handle bad response issue when adding query to a job#4pgupta-jw wants to merge 2 commits into
pgupta-jw wants to merge 2 commits into
Conversation
pgupta-jw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a SF query is added to the job, at times SF returns an XML response without batch ID or job ID. It seems to happen when ApiBatchLimit has been hit. And the salesforce_bulk gem we use does not handle this scenario gracefully.
It leads to annoying rollbar noise which lasts for quite a while until rate limit clears and things are back to normal.
https://rollbar.com/justworks/clockwork_web/items/7252
https://rollbar.com/justworks/clockwork_web/items/7251
This PR has changes to handle such scenarios, and raise a custom exception. It will help calling client (i.e. clockwork salesforce.rake task) to handle it gracefully. (PR for that to follow once we merge this and upgrade clockwork to this version of the gem)
Below ticket has more details on the debugging done.
Reference:
https://justworks.atlassian.net/browse/GROWTH-19
SF API Batch documentation:
https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/asynch_api_batches_create.htm