Apply network patches automatically in case of JupyterLite#26
Merged
Conversation
DerThorsten
approved these changes
Jan 7, 2026
JohanMabille
reviewed
Jan 7, 2026
| 'debugpy>=1.1.0,<2' | ||
| 'debugpy>=1.1.0,<2', | ||
| 'packaging', | ||
| 'pyodide-http' |
Member
There was a problem hiding this comment.
Can we require these additional packages for emscripten only?
Member
Author
There was a problem hiding this comment.
It's kind of annoying to do that since we'd have to maintain two recipes to achieve this. Right now the xeus-python-shell is a noarch package on conda-forge which is kind of nice.
Also those two dependencies are really small Python modules with no subdependencies, so the extra things to install isn't much.
Member
There was a problem hiding this comment.
Ah indeed, forget my comment then.
Member
Author
There was a problem hiding this comment.
#27 should makes your concerns a tiny bit better at least for the pip case, but for conda-forge there is no such concept of extras unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc. @MMesch