meta/sql: batch chunk_ref updates to reduce SQL round-trips#7018
Open
Xuyuchao-juice wants to merge 3 commits into
Open
meta/sql: batch chunk_ref updates to reduce SQL round-trips#7018Xuyuchao-juice wants to merge 3 commits into
Xuyuchao-juice wants to merge 3 commits into
Conversation
| if _, err := ses.Exec(m.sqlConv("update chunk_ref set refs=refs+1 where chunkid = ? AND size = ?"), id, size); err != nil { | ||
| return err | ||
| } | ||
| chunkRefDeltas[id]++ |
Contributor
There was a problem hiding this comment.
size维度丢失了, 其他地方也是. 后台任务做下处理就可以, 其他地方先不修改
e3fcc69 to
5ca56f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.