Component: Avoid sending mouse-drag events to a component whose mouse-down was consumed by a modal component - #1683
Open
emezeske wants to merge 1 commit into
Conversation
…-down was consumed by a modal component
emezeske
marked this pull request as ready for review
July 12, 2026 23:10
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a window's bottom-right corner resizer can snap the window instantly to its minimum size, if a CallOutBox happened to be open when the drag started. More generally, any component that captures state in mouseDown then runs its mouseDrag against stale state, because it received the drag without ever receiving the press.
That happens when a modal component consumes the mouse-down but dismisses itself asynchronously, as a CallOutBox with setDismissalMouseClicksAreAlwaysConsumed (true) does via postCommandMessage. The component under the mouse never gets the mouse-down, but internalMouseDrag only checks whether the target is blocked at the time each drag event arrives, so once the modal component finishes going away mid-gesture the drags get delivered anyway. In the resizer case, ResizableCornerComponent::originalBounds was never set.
Repro:
internalMouseUp already checks mouseDownWasBlocked before delivering, so this just applies the same check to mouseDrag: if the press that started the gesture was swallowed by a modal component, the drags shouldn't be delivered either.