fix(mc_control): fix controller-specific plugin lifecycle and cleanup datastore keys on controller switch#537
Open
Alhuuin wants to merge 2 commits into
Open
Conversation
Alhuuin
commented
May 27, 2026
Alhuuin
commented
- fixes the lifecycle of controller-specific plugins. They were previously handled as global plugins, and were still called with the next controllers.
- tracks datastore entries created by controller-specific plugins and removes them when removing the plugin. Duplicate datastore registrations could previously happen when re-entering a controller.
… datastore keys on controller switch
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.