Introduce JRL CMake Modules v2#798
Open
ahoarau wants to merge 350 commits into
Open
Conversation
This was referenced Dec 11, 2025
jorisv
requested changes
Dec 12, 2025
jorisv
requested changes
Dec 30, 2025
This was referenced Jan 6, 2026
arntanguy
reviewed
Jan 6, 2026
arntanguy
left a comment
Contributor
There was a problem hiding this comment.
Just gave it a try with SpaceVecAlg: jrl-umi3218/SpaceVecAlg#67
There seems to be an issue with BUILDSYSTEM_TARGETS, see my comment inline.
Besides that it worked just fine. I'll keep exploring during the week.
nim65s
reviewed
Jan 9, 2026
nim65s
left a comment
Collaborator
There was a problem hiding this comment.
That's a lot of work 😅
I did not look into external-modules yet, but here are some comments as a starting point.
9b26ecf to
62e72ef
Compare
jorisv
requested changes
Jan 22, 2026
nim65s
reviewed
Mar 5, 2026
nim65s
reviewed
Mar 11, 2026
arntanguy
reviewed
Mar 16, 2026
arntanguy
reviewed
Mar 16, 2026
This was referenced Mar 16, 2026
cmake322 is creating issues on macos26. It forces. clang18 which is no longer compatible with the latest Xcode SDK. cmake 3.22 is tested on ubuntu 22.04. Pixi build env is removed as it is used extensively in tests.
* renamed folders and structure for coherence * "pixi run test" works on all levels * added the CamelCase test * remove duplicated tests
…se without CHOLMODConfig.cmake
390528c to
1b6b807
Compare
nim65s
reviewed
Jun 10, 2026
4 tasks
header_visibility is already covering those cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce the
JRL CMake Modules v2, extracted from the repo: https://github.com/ahoarau/jrl-cmakemodules-v2The integration on the user-side can be done as follows https://github.com/ahoarau/nanoeigenpy/blob/db692b1dbe3fff76688550048fd3004ecbd1a2d7/cmake/get-jrl-cmakemodules.cmake
JRL_CMAKEMODULES_SOURCE_DIRpointing to the jrl repo source (example$env:JRL_CMAKEMODULES_SOURCE_DIR="C:/a/jrl-cmakemodules"v1andv2in projects.TODO:
COMPATIBLITY_OPTIONforjrl_cmake_dependent_option()release.cmakein python