Skip to content

Introduce JRL CMake Modules v2#798

Open
ahoarau wants to merge 350 commits into
jrl-umi3218:masterfrom
ahoarau:jrl-next
Open

Introduce JRL CMake Modules v2#798
ahoarau wants to merge 350 commits into
jrl-umi3218:masterfrom
ahoarau:jrl-next

Conversation

@ahoarau

@ahoarau ahoarau commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator

In this PR we introduce the JRL CMake Modules v2, extracted from the repo: https://github.com/ahoarau/jrl-cmakemodules-v2

The integration on the user-side can be done as follows https://github.com/ahoarau/nanoeigenpy/blob/db692b1dbe3fff76688550048fd3004ecbd1a2d7/cmake/get-jrl-cmakemodules.cmake

find_package(jrl-cmakemodules 1.2.0 CONFIG REQUIRED)
  • v1.2.0 will integrate the v2 folder, containing the new API.
  • Either set an env variable JRL_CMAKEMODULES_SOURCE_DIR pointing to the jrl repo source (example $env:JRL_CMAKEMODULES_SOURCE_DIR="C:/a/jrl-cmakemodules"
  • We do not intend to use both v1 and v2 in projects.

TODO:

  • Port the main modules
  • Test the integration in client repo (proxsuite, eigenpy, nanoeigenpy, coal)
  • Figure out why gersemi still needs to re-format the new modules
  • Add COMPATIBLITY_OPTION for jrl_cmake_dependent_option()
  • Port tests from original repo
  • Port CI from original repo
  • Rewrite release.cmake in python
  • Port pypa metadata

Comment thread v2/find-modules/FindAccelerate.cmake
Comment thread v2/modules/BoostPython.cmake Outdated
Comment thread v2/jrl-cmakemodules-v2/templates/__init__.py.in Outdated
Comment thread v2/jrl-cmakemodules-v2/CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/jrl-cmakemodules-v2/CMakeLists.txt Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/BoostPython.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated

@arntanguy arntanguy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gave it a try with SpaceVecAlg: jrl-umi3218/SpaceVecAlg#67
There seems to be an issue with BUILDSYSTEM_TARGETS, see my comment inline.

Besides that it worked just fine. I'll keep exploring during the week.

Comment thread v2/modules/jrl.cmake Outdated

@nim65s nim65s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work 😅

I did not look into external-modules yet, but here are some comments as a starting point.

Comment thread v2/find-modules/FindScipy.cmake Outdated
Comment thread v2/find-modules/FindScipy.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/templates/generate-dependencies.cmake.in
Comment thread v2/CMakeLists.txt Outdated
@ahoarau ahoarau force-pushed the jrl-next branch 3 times, most recently from 9b26ecf to 62e72ef Compare January 13, 2026 08:34
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/scripts/release.py Outdated
Comment thread v2/scripts/release.py Outdated
Comment thread v2/modules/jrl.cmake Outdated
Comment thread CMakeLists.txt
Comment thread v2/modules/jrl.cmake Outdated
Comment thread v2/modules/jrl.cmake Outdated
@ahoarau ahoarau force-pushed the jrl-next branch 2 times, most recently from 390528c to 1b6b807 Compare June 10, 2026 10:27
Comment thread pyproject.toml
ahoarau added 2 commits June 12, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants