fix: pass inputProps through DropdownList to DropdownListInput (per docs)#1168
Open
matthewbub wants to merge 1 commit into
Open
fix: pass inputProps through DropdownList to DropdownListInput (per docs)#1168matthewbub wants to merge 1 commit into
inputProps through DropdownList to DropdownListInput (per docs)#1168matthewbub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation suggests that we should be able to assign
inputPropsto the DropdownList component. Upon investigation it was discovered that theinputPropsare getting silently dropped for this component before it actually makes it to aninputelement (I checked the others, this is the only one effected).This issue causes critical WCAG violations - (needed aria-labels on those inputs) https://dequeuniversity.com/rules/axe/4.10/label. I ended up applying a fix downstream via
pnpm patchbut I figured ideally this fix should live in the library itself.React-Widgets Docs for reference: https://jquense.github.io/react-widgets/docs/DropdownList#inputProps