Feature/explain#240
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment on lines
+199
to
+207
| /*try { | ||
| const seen = localStorage.getItem("route_info_seen"); | ||
| if (seen !== "1") { | ||
| setShowModal(true); | ||
| } | ||
| } catch (e) { | ||
| // localStorage にアクセスできない環境ではモーダルを表示しておく | ||
| setShowModal(true); | ||
| }*/ |
There was a problem hiding this comment.
[nitpick] 本番想定のコードがコメントアウトされたままになっていますが、ハッカソンのデモが終わった後に切り替える際に、このコメントアウトを解除し忘れる可能性があります。環境変数や設定ファイルでモード切替を制御するか、少なくともコメントにTODOを追加することを検討してください。例：// TODO: デモ終了後に本番モードに切り替える
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関連issue
Resolves #239
変更概要
動作確認方法やスクリーンショット