feat: feature-gate signing providers#94
Open
zannis wants to merge 11 commits into
Open
Conversation
|
@zannis is attempting to deploy a commit to the joshaavecom's projects Team on Vercel. A member of the Team first needs to authorize it. |
chore: bump dependencies
zannis
force-pushed
the
feat/feature-gate-signing-providers
branch
from
1f52f71 to
6521987
Compare
feat: expose webhook types to Rust and Typescript SDKs
zannis
force-pushed
the
feat/feature-gate-signing-providers
branch
from
6521987 to
7ed0df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR feature-gates all 3rd party signing providers. They all stay enabled by default on
rrelayer_coreso this won't cause any breaking changes to the backend, but anyone importing the rust client (which itself importsrrelayer_core) now gets a much thinner crate to work with. This will resolve out dependabot alerts for clients as some 3rd party providers - eg. Google, Fireblocks - have dependencies with known vulnerabilities.I will also upgrade the existing rrelayer dependencies on an upcoming PR.