feat: router groups#14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds router groups functionality to the amp web framework, allowing developers to organize routes under common prefixes with shared middleware. This is a common pattern in web frameworks that improves code organization and reduces duplication.
Key changes:
- Introduces a new
grouptype andGroup()function for creating route groups with prefixes and middleware - Adds
Mux.Group()method to register groups with the router - Includes comprehensive unit tests for all group methods
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/amp/group.go | Defines the core group types and methods for creating and managing route groups with HTTP method handlers |
| pkg/amp/group_test.go | Comprehensive unit tests for all group struct methods and functionality |
| pkg/amp/mux.go | Adds Mux.Group() method to register groups and additional logging for server startup |
| go.mod | Updates Go version to 1.25 |
| .github/workflows/go.yml | Updates CI workflow to use Go 1.25 and reformats YAML structure |
| examples/group/main.go | Demonstrates usage of the new router groups feature |
| examples/group/README.md | Brief documentation for the group example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds router groups to amp!
Create a router group with