Rename PollAdd's "flags" arg to "poll_mask" and make it type-safe#12
Open
asayers wants to merge 3 commits into
Open
Rename PollAdd's "flags" arg to "poll_mask" and make it type-safe#12asayers wants to merge 3 commits into
asayers wants to merge 3 commits into
Conversation
Contributor
Author
|
I wonder if |
Collaborator
|
Sounds reasonable. It appears there's one test failure to look into though. |
Collaborator
|
Would you mind resolving the merge conflicts that have popped up in this PR? |
This it what the "io_uring_prep_poll_add" man page calls it. I think it's worth following their naming, since `io_uring_prep_poll_update()` contains an unrelated field called "flags", in addition to "poll_mask". (This opcode is not yet supported by rustix-uring, but I imagine it might be in the future.)
Contributor
Author
Ah, I didn't notice that this type lives in |
Contributor
Author
|
I think this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "io_uring_prep_poll_add" man page refers to this field as "poll_mask". I think it's worth following their naming, since
io_uring_prep_poll_update()contains an unrelated field called "flags", in addition to "poll_mask". (This opcode is not yet supported by rustix-uring, but I imagine it might be in the future.)