Parse Windows-style paths when path.parse is posix - #10
Open
dyk1454683243-sudo wants to merge 2 commits into
Open
dyk1454683243-sudo wants to merge 2 commits into
dyk1454683243-sudo wants to merge 2 commits into
Conversation
Reproduce the issue when path.parse is posix: drive-letter paths with backslashes should use win32 semantics, while posix paths stay unchanged. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
When path.parse is posix, drive-letter, UNC, and backslash paths were treated as a single filename. Detect those inputs and parse them with path.win32 so dirname/basename/name and isAbsolute match win32 semantics. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Problem
When Node's
path.parseis the posix implementation, Windows paths that use backslashes (and drive-letter / UNC forms) are treated as a single filename. That yields an emptydirname, a full-pathbasename/name, andisAbsolute: false.Example:
C:\Program Files\Projects\Example\launchFile.exeSolution
Detect Windows-style paths (drive letter
^[A-Za-z]:[\\/], UNC\\server\share, or backslash separators) and parse them withpath.win32.parse. Ordinary posix paths keep the existingpath.parsebehavior.isAbsoluteuses win32 rules for those paths so a drive or UNC path is absolute on non-Windows hosts as well.Existing aliases (
extname,basename,dirname,stem) are unchanged.Tests
C:\Program Files\...)C:/...drive pathpath.parseis posix