Add suport to env setted#53
Open
afranioce wants to merge 1 commit into
Open
Conversation
Owner
|
The change looks good, has tests, seems like it would work. I'm not too keen on merging it without understanding the purpose. Is this an implementation of #38? If so, is it reasonably complete? |
Author
|
I have a dynamic environment variable set outside the dotenv and replacing this variable would be interesting. example: # .env
SSL_CERT_FILE=${API_PATH}/config/cert/${API_HOST}.pem
SSL_KEY_FILE=${API_PATH}/config/cert/${API_HOST}.key// Get base path application
_, filename, _, _ := runtime.Caller(0)
os.Setenv("API_PATH", path.Dir(filename)+"/..")
var err error
if currentEnvironment, ok := os.LookupEnv("ENV"); ok == true {
err = godotenv.Load(os.ExpandEnv("$API_PATH/.env." + currentEnvironment))
} else {
err = godotenv.Load(os.ExpandEnv("$API_PATH/.env"))
} |
Author
|
Implement of #17 |
|
Hi, what is the problem with this PR? Do you need any help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.