fix: avoid trailing newline for empty Write map#270
Open
anshusinha26 wants to merge 1 commit into
Open
Conversation
anshusinha26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing environment maps to disk with
Write, an empty map should produce a zero-byte file instead of a file containing a single blank line.This fix preserves existing behavior for non-empty maps (dotenv content remains newline-terminated) while ensuring empty-map writes do not introduce phantom content. The change includes a regression test that writes an empty map to a temporary file and asserts the file is empty.