Add colormap legends with units to the raster layers#19
Merged
Conversation
The wind / precip-forecast / storm-potential overlays were color-only with no scale, so their values were unreadable. Lift the colormap stops into shared JS (rasterShared) and generate BOTH the GLSL ramp and a panel legend from them, so the bar always matches the map. Each visible raster layer now shows a gradient legend with low/mid/high ticks and units: wind m/s, precip dBZ, CAPE J/kg. The precip legend appears only in forecast mode (live radar uses its own palette).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the audit (ui-taste lane — "color-only raster layers have no legend scale/units").
The wind / precip-forecast / storm-potential overlays were color-only, so their values were unreadable. Lift the colormap stops into shared JS (
rasterShared) and generate both the GLSL ramp and a panel legend from them — the bar always matches the map (one source). Each visible raster layer now shows a gradient legend with low/mid/high ticks and units:Verified headless: all three legends render and the regenerated GLSL ramps paint identically. (The per-cursor value tooltip the audit also suggested is intentionally deferred — it needs a CPU-side grid, which conflicts with the upcoming perf fix that drops the getImageData roundtrip.)
tsc, biome, build pass.
Docs & attribution