Harden the GFS ingest (retries, missing-value guards, write order) [skip release]#17
Merged
Merged
Conversation
…ring - fetch_field retries transient failures (3 attempts, backoff) so one flaky GET in the ~57-step planet-wide fan-out no longer aborts the whole refresh. - A non-finite (missing) wind cell now encodes to the mid-byte (~0 m/s) instead of saturating to byte 0, which the web read as a false -40 m/s gale; scalar textures map non-finite to the transparent floor. - idx parsing distinguishes "no next record" (EOF, read to end) from a present- but-unparseable next offset (corruption, surfaced) and guards the end-1 underflow with checked_sub. - fetch_temps writes lattice.json before the citytile/latest.json pointer, so the pointer commits last and a reader never races a half-written snapshot. - NWS_AREA is validated as comma-separated 2-letter codes before it goes into the alerts query string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the audit (rust-correctness lane). Backend robustness only — no data-format or user-facing change, hence [skip release].
fetch_fieldretries transient failures (3 attempts, backoff). One flaky GET in the ~57-step planet-wide fan-out no longer aborts the whole refresh. (audit: low — "no retry on the GFS fan-out")end-1underflow withchecked_sub. (audit: low)fetch_tempswriteslattice.jsonbefore thecitytile/latest.jsonpointer, so the pointer commits last and a reader never races a half-written snapshot. (audit: low)fmt, clippy
-D warnings, and the gfs/contract/s3 tests all pass.Docs & attribution