Make NWS alerts track the timeline#16
Merged
Merged
Conversation
The alerts layer drew every active alert regardless of the timeline, while every other layer moves with it. Filter alert features to those in effect at the map-wide valid time (citytile snapshot + hour offset, the same basis precip uses), treating a missing onset/expires as unbounded on that side. The panel shows "N of M in effect" once the set is filtered. No ingest change — onset and expires already ride in AlertProps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the audit (web-ts / time-model lane) — and the behavior you spotted on prod.
The alerts layer's
buildignoredctx.time, so the alert polygons stayed fixed while precip/temp/wind/CAPE moved with the timeline. Now alerts are filtered to those in effect at the map-wide valid time (cityTiles.snapshotMs + time·3600s, the same basisprecipuses), with a missingonset/expirestreated as unbounded on that side.onset/expiresalready ride inAlertProps.tsc + biome clean.
Docs & attribution