Pin ci.yml GITHUB_TOKEN to read-only permissions#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a top-level
permissions: contents: readblock toci.yml, resolving all three open code-scanning alerts (actions/missing-workflow-permissions, CodeQL, medium severity) — one per CI job (web,rust,cdk).The CI workflow had no
permissions:block, so itsGITHUB_TOKENinherited the repository default rather than least-privilege. All three jobs only read the repo — checkout, install, build, lint, test,git diff, and an AWS-freecdk synth— so read-onlycontentsis sufficient. This also bringsci.ymlin line with the other workflows (deploy.yml,auto-release.yml,release.yml), which each already declare an explicit, scopedpermissionsblock.Fixes the alerts at https://github.com/johncarmack1984/stormdeck/security/code-scanning.
Docs & attribution
Merging deploys, so stale docs ship to production. Tick every box (or the N/A).
web/src/App.tsxandweb/src/basemap.ts) updated if a tile/data source was added, removed, or swapped.