Add glslint editor integration#7
Merged
Merged
Conversation
Recommend the glslint extension (johncarmack1984.glslint) so contributors get luma.gl/deck.gl-aware GLSL diagnostics, and add glsl-lsp.toml binding each shader to the modules it uses at link time plus a drift cross-check between the GLSL UBO blocks and modules.ts uniformTypes. Dev-tooling only — not part of the published package.
johncarmack1984
force-pushed
the
add-glslint-integration
branch
from
8b37334 to
fffdbf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommends the
johncarmack1984.glslintextension and addsglsl-lsp.toml(per-shader module bindings + a drift cross-check of the GLSL UBO blocks againstmodules.tsuniformTypes). Dev-tooling only — not in the npmfiles, so the published package is unchanged.