Conversation
The cell args sit in the args of `Cell`, so they are contravariant: a column that carries them does not fit a `Column<DataType>` parameter. The plugin helpers still asked for that, so a table with such a Cell could use no plugin at all. The args are inferred, so an app could not work around it. The helpers, the plugin methods they call and `meta.forColumn` now take the column meta, the table meta and the cell args, the way `columnsFor` already does. One internal constraint keeps `any` for the cell args, where it stands for a column of any table. Cowritten by Claude
`ColumnOrder` holds the columns it orders, so it needs the same parameters as the helpers. The plugin keeps one for its own table and does not read the Cells, so it holds the widest shape. Cowritten by Claude
`table.modifiers.columnHeader` and `resizeHandle` are given a column in a template, so they meet the same wall as the helpers. The plugin column API holds the widest shape, because a plugin is handed whatever column the table has. Cowritten by Claude
This was referenced Sep 22, 2026
Owner
Author
|
closing, see universal-ember@60dafd9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of universal-ember#202 (cfbb714).
A Cell's args sit in the args of
Cell, so they are contravariant. A column that carries them does not fit theColumn<DataType>parameter the plugin helpers ask for, so a table with such a Cell can use no plugin at all. The args are inferred, so an app cannot work around it.The helpers, the plugin methods they call and
meta.forColumnnow take the column meta, the table meta and the cell args, the waycolumnsForalready does. One internal constraint keepsanyfor the cell args, where it stands for a column of any table.plugins-with-cell-args.test.tscovers it: 10 errors without this change, none with it.tsc, prettier and eslint are clean on the package.Cowritten by Claude