Repository navigation
Raise JMESPathTypeError from ceil()/floor() on infinity and NaN - #394
Open
ApparentlyTejas wants to merge 1 commit into
Open
ApparentlyTejas wants to merge 1 commit into
ApparentlyTejas wants to merge 1 commit into
Conversation
Both functions passed their argument straight to math.ceil/math.floor, which raise the builtin OverflowError/ValueError on non-finite floats instead of a JMESPathError subclass. json.loads accepts Infinity and NaN by default, so data loaded the usual way can trigger this, and code that catches JMESPathError around search() doesn't catch the builtin exceptions. Every other invalid-argument case in this module raises JMESPathTypeError; this makes ceil()/floor() consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381.
ceil()andfloor()pass their argument straight tomath.ceil/math.floor, which raise on infinity and NaN:json.loadsacceptsInfinity/NaNby default, so data loaded the usual way can contain them. The@signature({"types": ['number']})decorator doesn't catch this —inf/nanare still Pythonfloat, which maps to the JMESPath "number" type; the check only validates the type category, not finiteness.Every other invalid-argument case in
functions.pyraisesexceptions.JMESPathTypeError, soOverflowError/ValueErrorleaking out here means code that catchesJMESPathErroraroundsearch()doesn't catch these. Went with raisingJMESPathTypeError(matching the existing convention) rather than returning the value unchanged, since that keeps the "callers catch JMESPathError" contract intact.