Repository navigation
Raise JMESPathTypeError for non-finite floor()/ceil() args - #391
Open
TrueFurina wants to merge 1 commit into
Open
TrueFurina wants to merge 1 commit into
TrueFurina wants to merge 1 commit into
Conversation
math.floor/ceil raise uncatchable OverflowError/ValueError on Infinity/NaN. json.loads accepts those by default, so data loaded the usual way reaches these functions. Surface them as JMESPathTypeError so callers catching JMESPathError handle them like any other bad function argument (closes jmespath#381).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
floor()andceil()pass their argument straight tomath.floor/math.ceil, which raise uncatchableOverflowError/ValueErroronInfinityandNaN. Python'sjson.loadsaccepts those literals by default, so JSON data loaded the usual way can contain them and reach these functions:Every other bad function argument in jmespath raises
JMESPathTypeError, so code that doestry: search(...) except JMESPathError:around a query cannot catch these.Fix
Guard the two functions with
math.isfinite()and raiseJMESPathTypeErrorfor non-finite inputs, matching the project's existing convention for invalid function arguments. Finite values are unaffected.Verification
tests/test_functions.py::test_floor_ceil_reject_non_finite(coversfloor/ceilonInfinity/NaN) andtest_floor_ceil_still_work_for_finite.993 passed, 1 skipped(baseline991 passed).Closes #381.