Skip to content

feat(p2p-06): add p2p service lifecycle shell (#671)#12

Open
jlon wants to merge 3 commits into
p2p-05-fetched-cache-backendfrom
p2p-06-service-lifecycle-shell
Open

feat(p2p-06): add p2p service lifecycle shell (#671)#12
jlon wants to merge 3 commits into
p2p-05-fetched-cache-backendfrom
p2p-06-service-lifecycle-shell

Conversation

@jlon

@jlon jlon commented Mar 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Introduce P2pService lifecycle ownership in the client filesystem stack.
  • Keep reads unchanged; this PR only establishes start/stop and stats shell behavior.

Design

  • Model service state explicitly as Disabled, Stopped, and Running.
  • Keep ownership in FsContext and bind startup/shutdown to filesystem lifecycle boundaries.

Implementation

  • Add P2pService, P2pState, and stats snapshot exports.
  • Construct the service from config and hook filesystem start/stop plus basic lifecycle tests.

Verification

  • cargo test -p curvine-client disabled_service_does_not_start
  • cargo test -p curvine-client enabled_service_transitions_between_stopped_and_running
  • cargo test -p curvine-client fs_context_creates_p2p_service_when_enabled

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@jlon jlon force-pushed the p2p-05-fetched-cache-backend branch from 48a468e to 92f1043 Compare March 26, 2026 10:26
@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from 2d9bc06 to 564aa24 Compare March 26, 2026 10:26
@jlon jlon force-pushed the p2p-05-fetched-cache-backend branch from 92f1043 to 5fbbdfc Compare March 27, 2026 09:32
@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from 564aa24 to dab5fb3 Compare March 27, 2026 09:32
@jlon jlon force-pushed the p2p-05-fetched-cache-backend branch from 5fbbdfc to 9a8bb64 Compare March 30, 2026 00:55
@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from dab5fb3 to 311b4d6 Compare March 30, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant