feat(p2p-07): add read acceleration baseline (#671)#11
Open
jlon wants to merge 2 commits into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
2d9bc06 to
564aa24
Compare
1376195 to
b2a02bc
Compare
564aa24 to
dab5fb3
Compare
b2a02bc to
3be7b3b
Compare
dab5fb3 to
311b4d6
Compare
3be7b3b to
9a154ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design
file_id + version_epoch + block_id + offto avoid stale cross-version hits.Implementation
BlockReaderandFsReaderBase.P2pService, populate local read cache, and add registry/cache integration tests.Verification
cargo test -p curvine-client worker_chunk_read_populates_local_cache_and_p2p_registrycargo test -p curvine-client running_services_share_published_chunks_and_cleanup_on_stop