JITSU-190 Remove env endpoints and route server billing internally - #1500
Merged
Merged
Conversation
absorbb
marked this pull request as ready for review
September 8, 2026 05:58
There was a problem hiding this comment.
Reviewed the removal of the environment-diagnostic endpoints and the new split between browser-visible and server-only billing URLs.
No actionable correctness, security, or user-visible regression findings. Confirmed all server-originated billing call sites use the internal URL with the existing authentication behavior, while app-config continues to expose only the public URL.
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JITSU-190Delete
/api/admin/envand remove the full-environment diagnostics option from/api/version. AddEE_CONNECTION_INTERNALfor server-originated billing requests, including backup credential exports, while app-config continues advertising the public billing URL to browsers. Existing authentication headers are unchanged; deployments without the internal URL retain the public fallback.Deploy this console code and configure the internal billing URL before enabling the public
/api/s3-connectionsdeny in jitsucom/jitsu-cloud-infra#99. Deployment stays manual.Validation: 7 URL unit tests, 21 integration tests (exports/internal routing and service token, backup retention, version diagnostics), console TypeScript check, and ESLint on changed files passed.