Skip to content

JITSU-190 Remove env endpoints and route server billing internally - #1500

Merged
absorbb merged 2 commits into
newjitsufrom
fix/jitsu-190-credential-endpoints
Sep 23, 2026
Merged

absorbb merged 2 commits into
newjitsufrom
fix/jitsu-190-credential-endpoints

Conversation

@absorbb

@absorbb absorbb commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

JITSU-190

Delete /api/admin/env and remove the full-environment diagnostics option from /api/version. Add EE_CONNECTION_INTERNAL for server-originated billing requests, including backup credential exports, while app-config continues advertising the public billing URL to browsers. Existing authentication headers are unchanged; deployments without the internal URL retain the public fallback.

Deploy this console code and configure the internal billing URL before enabling the public /api/s3-connections deny in jitsucom/jitsu-cloud-infra#99. Deployment stays manual.

Validation: 7 URL unit tests, 21 integration tests (exports/internal routing and service token, backup retention, version diagnostics), console TypeScript check, and ESLint on changed files passed.

@absorbb
absorbb marked this pull request as ready for review September 8, 2026 05:58

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the removal of environment diagnostics and the split between browser-visible and server-only billing URLs. I found no actionable correctness, security, or user-visible regression in this change set.

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the removal of the environment-diagnostic endpoints and the new split between browser-visible and server-only billing URLs.

No actionable correctness, security, or user-visible regression findings. Confirmed all server-originated billing call sites use the internal URL with the existing authentication behavior, while app-config continues to expose only the public URL.

@absorbb absorbb added the deploy:console Auto-deploy console to beta when this PR merges (JITSU-68) label Sep 23, 2026
@absorbb
absorbb merged commit 9cec0cc into newjitsu Sep 23, 2026
13 checks passed
@absorbb
absorbb deleted the fix/jitsu-190-credential-endpoints branch September 23, 2026 14:48
@github-actions

Copy link
Copy Markdown
Contributor

🚀 deploy:console label detected — triggered a beta console deployment to jitsu-cloud-infra. Track it in the deploy runs (newest at top): https://github.com/jitsucom/jitsu-cloud-infra/actions/workflows/deploy.yaml?query=event%3Aworkflow_dispatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy:console Auto-deploy console to beta when this PR merges (JITSU-68)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant