Skip to content

feat: signal per-endpoint diarize to the bridge via Colibri2#1291

Merged
bgrozev merged 3 commits into
masterfrom
diarization-endpoint-control
Jul 14, 2026
Merged

feat: signal per-endpoint diarize to the bridge via Colibri2#1291
bgrozev merged 3 commits into
masterfrom
diarization-endpoint-control

Conversation

@bgrozev

@bgrozev bgrozev commented Jul 14, 2026

Copy link
Copy Markdown
Member

Propagates a per-participant diarize flag from MUC presence to the videobridge via COLIBRI v2, so diarization can be enabled per endpoint (for multi-speaker endpoints such as room systems and dial-in) instead of only globally.

The client advertises the flag as a <jitsi_participant_diarize> presence element (lib-jitsi-meet participant property). jicofo reads it in ChatRoomMemberImpl.processPresence, threads it through ParticipantAllocationParametersParticipantInfo, and emits it as the diarize attribute on the COLIBRI v2 endpoint (create path only; the flag is static per session). Mirrors the existing useSsrcRewriting / supportsPrivateAddresses end-to-end pattern.

Part of a multi-repo change. The four Maven repos share the branch diarization-endpoint-control so CI builds them together; no dependency version bumps are included (they follow after jitsi-xmpp-extensions is released).


Related PRs (per-endpoint speaker diarization, multi-repo):

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Jul 14, 2026
jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.06%. Comparing base (db0f7ac) to head (cd4847c).

Files with missing lines Patch % Lines
...in/org/jitsi/jicofo/xmpp/muc/ChatRoomMemberImpl.kt 0.00% 4 Missing ⚠️
...tlin/org/jitsi/jicofo/bridge/colibri/Extensions.kt 0.00% 2 Missing ⚠️
...org/jitsi/jicofo/bridge/colibri/ParticipantInfo.kt 0.00% 2 Missing ⚠️
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1291      +/-   ##
============================================
- Coverage     27.08%   27.06%   -0.03%     
  Complexity      500      500              
============================================
  Files           130      130              
  Lines          8119     8129      +10     
  Branches       1251     1253       +2     
============================================
+ Hits           2199     2200       +1     
- Misses         5589     5598       +9     
  Partials        331      331              
Files with missing lines Coverage Δ
...i/jicofo/conference/ParticipantInviteRunnable.java 51.26% <100.00%> (+0.31%) ⬆️
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt 12.50% <0.00%> (-0.41%) ⬇️
...tlin/org/jitsi/jicofo/bridge/colibri/Extensions.kt 0.00% <0.00%> (ø)
...org/jitsi/jicofo/bridge/colibri/ParticipantInfo.kt 0.00% <0.00%> (ø)
...in/org/jitsi/jicofo/xmpp/muc/ChatRoomMemberImpl.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0f7ac...cd4847c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Jul 14, 2026
@bgrozev
bgrozev merged commit 3b66625 into master Jul 14, 2026
4 of 6 checks passed
@bgrozev
bgrozev deleted the diarization-endpoint-control branch July 14, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants