Skip to content

Replace json-simple with Jackson#1284

Merged
bgrozev merged 5 commits into
masterfrom
remove-json-simple
Jun 10, 2026
Merged

Replace json-simple with Jackson#1284
bgrozev merged 5 commits into
masterfrom
remove-json-simple

Conversation

@bgrozev

@bgrozev bgrozev commented Jun 1, 2026

Copy link
Copy Markdown
Member

Replace the org.json.simple dependency with Jackson (jackson-databind, jackson-module-kotlin).

  • Debug state methods now return JsonNode
  • Update jitsi-utils to 1.0-SNAPSHOT

bgrozev added 3 commits June 1, 2026 08:24
Replace org.json.simple dependency with Jackson (jackson-databind, jackson-module-kotlin).
Update jitsi-utils to 1.0-SNAPSHOT.
Debug state methods now return JsonNode.
Replace mapper.createObjectNode()/createArrayNode() with
JsonNodeFactory.instance.objectNode()/arrayNode() everywhere.
Remove now-unused ObjectMapper instances and imports.
OrderedJsonObject is removed from jitsi-utils. Replace all call sites
with JsonNodeFactory.instance.objectNode() directly.

@JonathanLennox JonathanLennox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending update of dependencies

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.98582% with 220 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.20%. Comparing base (793a94d) to head (6d14950).

Files with missing lines Patch % Lines
...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt 6.45% 29 Missing ⚠️
...src/main/kotlin/org/jitsi/jicofo/JicofoServices.kt 0.00% 25 Missing ⚠️
...n/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoomImpl.kt 0.00% 22 Missing ⚠️
...in/org/jitsi/jicofo/xmpp/muc/ChatRoomMemberImpl.kt 0.00% 17 Missing ⚠️
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt 0.00% 16 Missing ⚠️
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt 0.00% 13 Missing ⚠️
...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt 0.00% 12 Missing ⚠️
...lin/org/jitsi/jicofo/jibri/JibriDetectorMetrics.kt 0.00% 10 Missing ⚠️
...c/main/kotlin/org/jitsi/jicofo/ktor/Application.kt 0.00% 9 Missing ⚠️
...kotlin/org/jitsi/jicofo/xmpp/jingle/JingleStats.kt 0.00% 8 Missing ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1284   +/-   ##
=========================================
  Coverage     26.19%   26.20%           
- Complexity      468      469    +1     
=========================================
  Files           126      126           
  Lines          7875     7908   +33     
  Branches       1215     1212    -3     
=========================================
+ Hits           2063     2072    +9     
- Misses         5499     5523   +24     
  Partials        313      313           
Files with missing lines Coverage Δ
.../main/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoom.kt 0.00% <ø> (ø)
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt 0.00% <ø> (ø)
...g/jitsi/jicofo/conference/JitsiMeetConference.java 0.00% <ø> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 37.61% <100.00%> (+0.18%) ⬆️
...lin/org/jitsi/jicofo/conference/SourceSignaling.kt 93.93% <100.00%> (+0.39%) ⬆️
...otlin/org/jitsi/jicofo/conference/source/Source.kt 0.00% <0.00%> (ø)
...tlin/org/jitsi/jicofo/xmpp/jingle/JingleSession.kt 0.00% <0.00%> (ø)
...tlin/org/jitsi/jicofo/util/PreferenceAggregator.kt 74.62% <83.33%> (ø)
.../main/kotlin/org/jitsi/jicofo/xmpp/XmppServices.kt 0.00% <0.00%> (ø)
...n/org/jitsi/jicofo/xmpp/muc/ChatRoomRoleManager.kt 40.29% <66.66%> (ø)
... and 26 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793a94d...6d14950. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Jun 10, 2026
@bgrozev bgrozev merged commit 72d22de into master Jun 10, 2026
5 of 6 checks passed
@bgrozev bgrozev deleted the remove-json-simple branch June 10, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants