Skip to content

Forward rtcStatsEnabled to Jibri invite#1283

Merged
bgrozev merged 2 commits into
masterfrom
jibri-rtcstats
May 28, 2026
Merged

Forward rtcStatsEnabled to Jibri invite#1283
bgrozev merged 2 commits into
masterfrom
jibri-rtcstats

Conversation

@bgrozev

@bgrozev bgrozev commented May 28, 2026

Copy link
Copy Markdown
Member

When jicofo invites a Jibri instance, include the conference-level rtcStatsEnabled flag in the start IQ.

  • JibriSession accepts and forwards the flag via JibriIq.setRtcStatsEnabled()
  • JibriRecorder and JibriSipGateway read the flag from conference.isRtcStatsEnabled

Depends on jitsi/jitsi-xmpp-extensions#138.

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.19%. Comparing base (a095944) to head (e4369a2).

Files with missing lines Patch % Lines
...ain/kotlin/org/jitsi/jicofo/jibri/JibriRecorder.kt 0.00% 1 Missing ⚠️
...n/kotlin/org/jitsi/jicofo/jibri/JibriSipGateway.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1283      +/-   ##
============================================
+ Coverage     26.18%   26.19%   +0.01%     
  Complexity      468      468              
============================================
  Files           126      126              
  Lines          7871     7875       +4     
  Branches       1215     1215              
============================================
+ Hits           2061     2063       +2     
- Misses         5497     5499       +2     
  Partials        313      313              
Files with missing lines Coverage Δ
...main/java/org/jitsi/jicofo/jibri/JibriSession.java 41.84% <100.00%> (+0.49%) ⬆️
...ain/kotlin/org/jitsi/jicofo/jibri/JibriRecorder.kt 8.82% <0.00%> (-0.14%) ⬇️
...n/kotlin/org/jitsi/jicofo/jibri/JibriSipGateway.kt 16.07% <0.00%> (-0.30%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a095944...e4369a2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bgrozev bgrozev merged commit ed8f3c4 into master May 28, 2026
4 of 5 checks passed
@bgrozev bgrozev deleted the jibri-rtcstats branch May 28, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants