Skip to content

feat: Start sessions immediately when transcribing is enabled#1281

Merged
bgrozev merged 1 commit into
masterfrom
transcription-min-participants
Apr 29, 2026
Merged

feat: Start sessions immediately when transcribing is enabled#1281
bgrozev merged 1 commit into
masterfrom
transcription-min-participants

Conversation

@bgrozev

@bgrozev bgrozev commented Apr 26, 2026

Copy link
Copy Markdown
Member

When enableTranscription is true, bypass the min-participants threshold so Jingle/Colibri sessions start with a single participant.

Two changes in JitsiMeetConferenceImpl:

  • checkMinParticipants(): set minParticipants = 1 when transcription is enabled
  • setEnableTranscribing(true): if members are already in the room but sessions have not started yet (participants empty), trigger invitations immediately

Also extracts inviteAllChatMembers() to avoid code duplication between the two callsites.

When transcribing is enabled, bypass the min-participants threshold and
start Jingle/Colibri sessions immediately. Also trigger invitations for
participants already in the room when transcribing gets enabled.
@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.36%. Comparing base (8e8c9d2) to head (501ca61).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 26.31% 12 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1281      +/-   ##
============================================
- Coverage     26.38%   26.36%   -0.03%     
- Complexity      474      475       +1     
============================================
  Files           126      126              
  Lines          7861     7871      +10     
  Branches       1213     1215       +2     
============================================
+ Hits           2074     2075       +1     
- Misses         5478     5486       +8     
- Partials        309      310       +1     
Files with missing lines Coverage Δ
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 38.43% <26.31%> (-0.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8c9d2...501ca61. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bgrozev bgrozev merged commit 593462c into master Apr 29, 2026
4 of 6 checks passed
@bgrozev bgrozev deleted the transcription-min-participants branch April 29, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants