feat: Start sessions immediately when transcribing is enabled#1281
Merged
Conversation
When transcribing is enabled, bypass the min-participants threshold and start Jingle/Colibri sessions immediately. Also trigger invitations for participants already in the room when transcribing gets enabled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
============================================
- Coverage 26.38% 26.36% -0.03%
- Complexity 474 475 +1
============================================
Files 126 126
Lines 7861 7871 +10
Branches 1213 1215 +2
============================================
+ Hits 2074 2075 +1
- Misses 5478 5486 +8
- Partials 309 310 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
damencho
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
enableTranscriptionis true, bypass themin-participantsthreshold so Jingle/Colibri sessions start with a single participant.Two changes in
JitsiMeetConferenceImpl:checkMinParticipants(): setminParticipants = 1when transcription is enabledsetEnableTranscribing(true): if members are already in the room but sessions have not started yet (participants empty), trigger invitations immediatelyAlso extracts
inviteAllChatMembers()to avoid code duplication between the two callsites.