Skip to content

Log audit errors when partial results are allowed (v2 backport) #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jordanh1996 wants to merge 1 commit into from
+2 −2
Closed

Log audit errors when partial results are allowed (v2 backport) #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scanrepository/scanrepository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func (cfp *ScanRepositoryCmd) fixVulnerablePackages(repository *utils.Repository
err = cfp.fixIssuesSeparatePRs(repository, vulnerabilitiesByWdMap)
}
if err != nil {
return utils.CreateErrorIfPartialResultsDisabled(cfp.scanDetails.AllowPartialResults(), fmt.Sprintf("failed to fix vulnerable dependencies: %s", err.Error()), err)
return utils.CreateErrorIfPartialResultsDisabled(cfp.scanDetails.AllowPartialResults(), "failed to fix vulnerable dependencies", err)
}
return
}
Expand Down
2 changes: 1 addition & 1 deletion utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ func isUrlAccessible(url string) bool {
// This function checks if partial results are allowed by the user. If so instead of returning an error we log the error and continue as if we didn't have an error
func CreateErrorIfPartialResultsDisabled(allowPartial bool, messageForLog string, err error) error {
if allowPartial {
log.Warn(messageForLog)
log.Warn(fmt.Sprintf("%s: %v", messageForLog, err))
return nil
}
return err
Expand Down
Loading