Fix in getFrogbot.sh - Use credentials only when REMOTE_PATH is set#1347
Merged
Merged
Conversation
Restore REMOTE_PATH gating in download_to, head_request, and storage_request so installs from releases.jfrog.io stay anonymous when JF_ACCESS_TOKEN or JF_USER are set for the scan only. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
removed
the
safe to test
attiasas
approved these changes
Jun 4, 2026
attiasas
left a comment
attiasas
left a comment
Contributor
There was a problem hiding this comment.
LGTM, make sure if you also need it for v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal fix in buildscripts/getFrogbot.sh: credentials are only used when REMOTE_PATH is set (i.e. when JF_RELEASES_REPO is configured).
Updated: download_to, head_request, storage_request
Behavior:
No JF_RELEASES_REPO → download/checksum calls to releases.jfrog.io are anonymous (no JF_ACCESS_TOKEN / JF_USER).
JF_RELEASES_REPO set → same as before: Bearer token or basic auth against the customer’s JF_URL.
This restores the pre–2.34.0 / v3.1.x pattern and addresses both customer 401 reports. dash -n still passes.