Skip to content

[artifactory] Add RTFS pod label values#2336

Open
omribz156 wants to merge 1 commit into
jfrog:masterfrom
omribz156:codex/rtfs-pod-labels
Open

[artifactory] Add RTFS pod label values#2336
omribz156 wants to merge 1 commit into
jfrog:masterfrom
omribz156:codex/rtfs-pod-labels

Conversation

@omribz156

Copy link
Copy Markdown

PR Checklist

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in values.yaml
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Adds a shared rtfs.labels value for the Artifactory and Artifactory HA charts, and renders those labels on both the RTFS Deployment metadata and the RTFS pod template metadata.

rtfs.deployment.labels is preserved as a Deployment-only label override. The new rtfs.labels mirrors the existing chart pattern used by workloads such as Artifactory and NGINX where a single labels value is applied to both the controller object and pods.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2309

Verification:

  • git diff --check
  • rg 'rtfs\.labels|Labels to add to the RTFS Deployment' -n stable\artifactory stable\artifactory-ha

I could not run helm template/make lint locally because this Windows workspace does not have helm, kubectl, or kubeval installed.

Special notes for your reviewer:

I left the chart version unchecked because there are active automated Artifactory release PRs in flight; happy to adjust the version bump if you prefer it in this PR.

This was implemented with Codex assistance, with the patch kept focused and manually reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[artifactory] rtfs-deployment.yaml lacks values knob for pod template labels

1 participant