[artifactory] Add RTFS pod label values#2336
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
[artifactory])What this PR does / why we need it:
Adds a shared
rtfs.labelsvalue for the Artifactory and Artifactory HA charts, and renders those labels on both the RTFS Deployment metadata and the RTFS pod template metadata.rtfs.deployment.labelsis preserved as a Deployment-only label override. The newrtfs.labelsmirrors the existing chart pattern used by workloads such as Artifactory and NGINX where a single labels value is applied to both the controller object and pods.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2309Verification:
git diff --checkrg 'rtfs\.labels|Labels to add to the RTFS Deployment' -n stable\artifactory stable\artifactory-haI could not run
helm template/make lintlocally because this Windows workspace does not havehelm,kubectl, orkubevalinstalled.Special notes for your reviewer:
I left the chart version unchecked because there are active automated Artifactory release PRs in flight; happy to adjust the version bump if you prefer it in this PR.
This was implemented with Codex assistance, with the patch kept focused and manually reviewed.