Skip to content

Fix documentation and improve default http client#29

Merged
jetelain merged 3 commits into
mainfrom
misc-improvements
May 5, 2026
Merged

Fix documentation and improve default http client#29
jetelain merged 3 commits into
mainfrom
misc-improvements

Conversation

@jetelain

@jetelain jetelain commented May 5, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates library documentation around rendering APIs, centralizes default HttpClient creation for DEM downloads, and adds a demo application intended to exercise README examples against the current APIs.

Changes:

  • Corrects README examples for PDF rendering and topographic map setup.
  • Extracts DEM HTTP client creation into a shared helper and reuses it from database entry points.
  • Adds a DemoApp project to the solution to compile/run documentation-style samples.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Pmad.Drawing/README.md Updates the PDF example to use the current Render.ToPdf overload.
Pmad.Cartography.sln Adds DemoApp to the solution and updates solution configuration metadata.
Pmad.Cartography.Drawing/README.md Refreshes topographic rendering/PDF examples to match current APIs.
MapToolkit/Databases/WellKnownDatabases.cs Switches well-known DEM storages to the shared HTTP client helper.
MapToolkit/Databases/HttpClientHelper.cs Introduces centralized HttpClient creation with the default User-Agent.
MapToolkit/Databases/DemHttpStorage.cs Adds XML documentation and routes the Uri constructor through the helper.
DemoApp/Program.cs Adds an executable sample covering README scenarios across the packages.
DemoApp/DemoApp.csproj Defines the new .NET 8 demo application project and references.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DemoApp/Program.cs
Comment thread DemoApp/Program.cs
Comment thread Pmad.Cartography.Drawing/README.md
Comment thread MapToolkit/Databases/DemHttpStorage.cs Outdated
Comment thread MapToolkit/Databases/HttpClientHelper.cs
jetelain and others added 2 commits May 5, 2026 20:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jetelain jetelain merged commit e63e924 into main May 5, 2026
1 check passed
@jetelain jetelain deleted the misc-improvements branch May 5, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants