Fix documentation and improve default http client#29
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates library documentation around rendering APIs, centralizes default HttpClient creation for DEM downloads, and adds a demo application intended to exercise README examples against the current APIs.
Changes:
- Corrects README examples for PDF rendering and topographic map setup.
- Extracts DEM HTTP client creation into a shared helper and reuses it from database entry points.
- Adds a
DemoAppproject to the solution to compile/run documentation-style samples.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
Pmad.Drawing/README.md |
Updates the PDF example to use the current Render.ToPdf overload. |
Pmad.Cartography.sln |
Adds DemoApp to the solution and updates solution configuration metadata. |
Pmad.Cartography.Drawing/README.md |
Refreshes topographic rendering/PDF examples to match current APIs. |
MapToolkit/Databases/WellKnownDatabases.cs |
Switches well-known DEM storages to the shared HTTP client helper. |
MapToolkit/Databases/HttpClientHelper.cs |
Introduces centralized HttpClient creation with the default User-Agent. |
MapToolkit/Databases/DemHttpStorage.cs |
Adds XML documentation and routes the Uri constructor through the helper. |
DemoApp/Program.cs |
Adds an executable sample covering README scenarios across the packages. |
DemoApp/DemoApp.csproj |
Defines the new .NET 8 demo application project and references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.