Skip to content

intoduce setup.py#51

Closed
Titotix wants to merge 1 commit into
jesparza:masterfrom
Titotix:setuptools
Closed

intoduce setup.py#51
Titotix wants to merge 1 commit into
jesparza:masterfrom
Titotix:setuptools

Conversation

@Titotix

@Titotix Titotix commented Feb 17, 2016

Copy link
Copy Markdown

Create an importable module for peepdf with setuptools
So we can use easily peepdf as a lib, and somehow fix the pointed issue by #50. (ImportException raised if we don't launch our script from peepdf repo.)
I think this PR and #50 should be both merge, although this one will fix the issue of #50 while running python setup.py install/python setup.py develop.
btw, do you think about uploading your project to pypi ?

@Titotix

Titotix commented Feb 17, 2016

Copy link
Copy Markdown
Author

This PR is not fully working ! :/
The setup.py script here only install the included dependencies (colorama, aespython, jsbeautifier). So it is definitely wrong.

To properly create a module it needs to create a repo (let's say peepdf/ ) and to putt all code inside it. Then to adapt all import in the code.
@jesparza : Do you agree on this ? Thoughts anyway ?

@Titotix Titotix closed this Feb 17, 2016
@Titotix

Titotix commented Feb 17, 2016

Copy link
Copy Markdown
Author

For ease of use, I needed this modification anyway, so I did it.
See https://github.com/Titotix/peepdf/tree/setupv4
If you would like a PR for it, I would be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant