Skip to content

feat: Add new feature to disable topicAbort at project level#1001

Open
panicking wants to merge 1 commit into
jenkinsci:masterfrom
panicking:feat/disable-topic-abort-job
Open

feat: Add new feature to disable topicAbort at project level#1001
panicking wants to merge 1 commit into
jenkinsci:masterfrom
panicking:feat/disable-topic-abort-job

Conversation

@panicking

Copy link
Copy Markdown
Contributor

Allow to disable the topic abort at project level. Without change the current behavior we have project where topic abort is needed at policy level and some project where we want it disabled

Testing done

Deploy in my envriroment and test if we can override the policy

Submitter checklist

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x ] Ensure that the pull request title represents the desired changelog entry
  • [x ] Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Allow to disable the topic abort at project level. Without
change the current behavior we have project where topic abort
is needed at policy level and some project where we want it disabled

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
@panicking

Copy link
Copy Markdown
Contributor Author

@rsandell here is building correctly. Is there any limitation of timeout in CI?

@rsandell

Copy link
Copy Markdown
Member

Maybe, the same tests are breaking on another PR as well and are working fine on my machine.
I was looking at just disabling them but the feature that the tests are covering won't have any tests in that case.

@panicking

Copy link
Copy Markdown
Contributor Author

Maybe, the same tests are breaking on another PR as well and are working fine on my machine. I was looking at just disabling them but the feature that the tests are covering won't have any tests in that case.

Can you please review or suggest change?

@rsandell

rsandell commented Mar 7, 2026

Copy link
Copy Markdown
Member

Normally I would just delete tests that are behaving like this, but in this case it is the only tests that are testing that functionality, so I don't want to throw them away without replacements of some sort.
I have been tinkering with running a real Gerrit in docker and using testcontainers, but it turned out to be not as easy as I'd hoped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants