Fix logic errors in deprecated functions filtering#425
Merged
Conversation
jjlin
reviewed
May 21, 2026
| video_tag.setTagLine(item_details.tagline) | ||
| video_tag.setStudios(item_details.studio) | ||
| if item_details.studio: | ||
| video_tag.setStudios(item_details.studio) |
Contributor
There was a problem hiding this comment.
Just curious, why are only studio and production_location treated specially? Is it documented somewhere that these specific fields are optional or something?
Member
Author
There was a problem hiding this comment.
Those functions accept lists, but if you hand them an empty list they explode. I didn't see that behavior with the ones that accept strings, or at least none of my media triggered errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.