Replace deprecated Kodi listitem setters#416
Conversation
|
Good catches, thanks for review |
|
hi @mcarlton00 @jjlin thanks for your work here. i've used this patch, and modified it to make it work. tested it on the latest kodi nightly builds with no more errors. I've also fixed up the other deprecation warnings for ListItem.setInfo(). You can see the diff with all the changes here, and apply them if you'd like. Or should I submit another PR? |
|
Removed incorrect not operators from the cast and studio conditional checks so the script actually reads the metadata instead of skipping it. Fixed a native typo by changing video_tag.setCase to the correct API method video_tag.setCast. Added filters and string conversions (ensure_text) to all metadata arrays to prevent Kodi from crashing when Jellyfin sends empty or None values from poorly scraped media. Explicit List Casting: Wrapped the variables passed to Kodi's video tags in explicit list() functions to satisfy the C++ wrapper's strict type-checking and resolve the "Tuple or List" crash. Updated the script to convert basic text dictionaries into dedicated xbmc.Actor objects, which is strictly required by modern Kodi versions (Nexus and above). |
|
If you want to open a separate PR we can compare against that's fine. I'm not going to pull your commits in here because I don't feel like dealing with the inevitable merge conflicts |
|
Alright, PR opened. |
|
Need to find one of my Pis and spin up an older version of libreelec to test the ugly Kodi 19 bits |
Fixes #406