Fix AgentBoard cleanup tickets

[jbcrane13]

Summary

• Dedupe GitHub service configuration behind WorkStore configuration change detection.
• Retain attachment upload progress observations until completion/cancel and make cache collection refreshes upsert/no-op instead of delete-all.
• Add explicit REST/SSE request timeout contracts and migrate the iOS root to the modern SwiftUI Tab API.

Closes #109
Closes #111
Closes #112
Closes #113
Closes #114
Closes #115

Verification

• swiftformat --config .swiftformat $(git diff --name-only -- "*.swift")
• swiftlint lint --strict --config .swiftlint.yml
• xcodebuild test -quiet -project AgentBoard.xcodeproj -scheme AgentBoard -destination "platform=macOS" CODE_SIGNING_ALLOWED=NO
• xcodebuild build -quiet -project AgentBoard.xcodeproj -scheme AgentBoardMobile -destination "generic/platform=iOS Simulator" CODE_SIGNING_ALLOWED=NO
• xcodebuild build -quiet -project AgentBoard.xcodeproj -scheme AgentBoardCompanion -destination "platform=macOS" CODE_SIGNING_ALLOWED=NO

Note: iOS build still emits pre-existing warnings in AttachmentPicker and SettingsScreen; no new warning class from this patch.

[Copilot]

Pull request overview

This PR addresses a set of cleanup tickets across AgentBoardCore and AgentBoardMobile by reducing redundant configuration work, fixing attachment upload progress observation lifetime, reducing SwiftData write amplification, adding explicit network request timeouts, and modernizing the iOS tab UI to the newer SwiftUI Tab API.

Changes:

• Dedupe GitHub service configuration in WorkStore behind settings change detection.
• Replace cache “delete-all then insert-all” refreshes with update/insert/delete (and no-op when unchanged).
• Add explicit per-endpoint timeout contracts for REST and SSE, and migrate iOS root tabs to SwiftUI’s modern Tab API.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
AgentBoardCore/Stores/WorkStore.swift	Injects a GitHubWorkServicing abstraction and dedupes configure calls via an applied-configuration snapshot.
AgentBoardCore/Services/GitHubWorkService.swift	Adds GitHubWorkServicing protocol and applies explicit list vs mutation request timeouts.
AgentBoardCore/Services/CompanionClient.swift	Introduces explicit request timeout categories (list/mutation/stream) and applies them per endpoint.
AgentBoardCore/Services/AttachmentUploadService.swift	Retains KVO progress observations until upload completion/cancel and cleans them up deterministically.
AgentBoardCore/Persistence/AgentBoardCache.swift	Reworks replace APIs to update/insert/delete with change detection to avoid delete-all amplification.
AgentBoardCore/Stores/SettingsStore.swift	Adds silent option to Hermes profile selection to avoid user-facing toast on bootstrap/apply.
AgentBoardMobile/MobileRootView.swift	Migrates to modern SwiftUI Tab(value:) API and removes global tab bar appearance mutations.
AgentBoardTests/WorkStoreTests.swift	Adds coverage ensuring GitHub service configuration is only applied when settings change.
AgentBoardTests/SettingsStoreTests.swift	Adds regression test ensuring bootstrap applies selected Hermes profile silently.
AgentBoardTests/GitHubWorkServiceTests.swift	Adds assertions for list/mutation request timeout behavior.
AgentBoardTests/CompanionClientEventsTests.swift	Adds assertions for list/mutation timeouts and “long-lived” SSE request behavior.
AgentBoardTests/AgentBoardCacheTests.swift	Adds test ensuring work-item replacement updates existing records rather than replacing identity.
AgentBoardTests/NativeSwiftUIInterfaceTests.swift	Updates interface-contract tests for Tab API migration and the new cache/upload implementations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.