Using openmc material.deplete()#37
Merged
Merged
Conversation
Collaborator
Author
|
Ah this is reloading the nuclear data each time and therefore taking a long time to compute. I should make use of the new openmc.lib.TemporarySession feature to speed this up. |
Collaborator
Author
|
I added the temporary session CI is now passing but taking 4 hours. This is still an increase from the 40 mins it. I think we need to add session argument to the openmc.Material.deplete function to see if that helps |
Collaborator
Author
|
just updated this PR as there have been some improvements in openmc deplete and I notice it brought the time down from 4 hours to 2 hours. still not as quick as the existing code so not ready to merge. |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
Awesome this small change took us down to 31 mins |
Collaborator
Author
|
Super reduce chain reduce to 28 mins. I think this is ready for review now. |
jbae11
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the develop branch we now have the material.deplete method available. So in theory we can replace quite a lot of code by using that method