Relax maxPage to fetch watching repos#221
Open
pocke wants to merge 1 commit into
Open
Conversation
Ten is too small for the threshold because actually I have 1000+ watching repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases maxPage threshold to fetch watching repositories from 10 to 30.
The current threshold is too small for me because I have 1,000+ watching repos which need 10+ pages.
I'm not sure which number is appropriate for the threshold, but I guess
30is enough in most cases.By the way, this change is related to #220 a bit. This PR will increase query executions but #220 will reduce the impact of the increased query execution.