[codex] Add Claude provider support and isolate chat sessions#85
Merged
Conversation
Replace the long vertical scroll on the design system page with a scrollable tab carousel so colors, typography, spacing, components, etc. each get a focused view instead of being stacked end to end. - DesignSystemReferenceView: dynamic tab list (only sections with content), sticky horizontal pill carousel with a sliding selection highlight (matchedGeometryEffect), count badges, cross-fade between panels, and accessibility traits. Sections are derived from the catalog and selection resets when the catalog changes. - DesignSystemBrowserView: give reference catalogs a fixed header with the carousel pinned below (no nested scroll); other states keep the existing scroll layout. - EaselDesignSystemCatalogHTMLRenderer: mirror the same hierarchy in the canvas web preview with an accessible role=tablist carousel, keeping the required element IDs and catalog-loading flow intact.
This reverts commit 6d44403.
This reverts commit fd37bc1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the embedded chat provider-aware and adds Claude support alongside the existing Codex flow. It keeps the Codex UI presentation patterns while adding Claude configuration, model selection, provider persistence, and runtime handling.
It also fixes the session-conflict regression found during testing: each chat session now retains its own
ChatViewModeland dependency context, and the SwiftUI chat surface is keyed by the selected view model so switching sessions does not reuse stale@State. Background Claude or Codex turns no longer steal visible session state when their runtime reports session changes.The earlier design-system asset bundling experiment is reverted in this branch, so the net PR excludes that behavior.
What changed
askuserquestiontool usage because the embedded UI does not support that interaction.ChatServiceso sessions do not conflict when switching, creating new sessions, or returning to a running Claude session.ChatScreenby the activeChatViewModelidentity so SwiftUI swaps to the selected session model.Validation
swift test --package-path Packages/EaselClaudeCodeUIpassed: 140 tests.swiftc -parsepassed for the editedEaselChatSwift files.git diff --checkpassed.swift test --package-path Packages/EaselChat --filter ChatServiceTestsis currently blocked before reaching these tests by the existing externalCodeEditSymbolscheckout error:type 'Bundle' has no member 'module'.