Skip to content

[codex] Fix monorepo file search fallback#392

Merged
jamesrochabrun merged 1 commit into
mainfrom
codex/fix-monorepo-file-search
Jun 15, 2026
Merged

[codex] Fix monorepo file search fallback#392
jamesrochabrun merged 1 commit into
mainfrom
codex/fix-monorepo-file-search

Conversation

@jamesrochabrun

Copy link
Copy Markdown
Owner

Summary

Fixes the Cmd+P quick file search regression where monorepos could always show no results after the optimized search path failed to produce a usable local index.

Root Cause

The git-backed local fallback could time out or return a partial list while indexing large repositories. When Spotlight had no usable result and the broad local index had no matching entries, Cmd+P had no query-specific rescue path and surfaced an empty result set.

Changes

  • Drain git ls-files stdout reliably even when the process times out.
  • Add a query-specific git file enumeration fallback when the broad local index has no matches.
  • Keep ignored files filtered out while preserving tracked and untracked search hits.
  • Add focused tests for partial monorepo index misses and real git query enumeration.

Validation

xcodebuild test -scheme AgentHubCore-Tests -destination 'platform=macOS' -test-timeouts-enabled YES -skipPackagePluginValidation -only-testing:AgentHubTests/FileIndexServicePrivacyTests -quiet

Exit code: 0.

@jamesrochabrun jamesrochabrun marked this pull request as ready for review June 15, 2026 18:35
@jamesrochabrun jamesrochabrun merged commit f9bacf3 into main Jun 15, 2026
1 check passed
@jamesrochabrun jamesrochabrun deleted the codex/fix-monorepo-file-search branch June 15, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant