Repository navigation
fix(#41): keep non-image Matroska attachments when adding cover art - #42
Merged
Merged
Conversation
…r art TagLib exposes every Matroska attachment as a picture, including the fonts that ASS/SSA subtitles need. Setting Tag.Pictures to the cover alone deleted them. For Matroska files only image attachments are now replaced; other file types still get the cover as their only picture.
Owner
|
Thanks for the fix! This is released in v4.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #41.
When adding cover art to a Matroska file,
FileWriternow only replaces image attachments and keeps all other attachments (e.g. the fonts used by ASS/SSA subtitles). Other formats are unchanged and still get the cover as their only picture.Result
With the steps from #41, listing the attachments
ffprobe -v error -show_entries stream=codec_type:stream_tags=filename,mimetype \ -of compact=p=0 "Movie (2020).mkv"now results in
instead of
Testing
Should_KeepNonImageAttachments_WhenAddingCoverArtToMatroska, using a small MKV inAutoTag.Core.Test/TestData(generate.shrecreates it with ffmpeg). It fails without the fix.AutoTag.Core.Test: all tests pass locally.AutoTag.CLI.Test: passes locally with a TMDB API key.