Align CLAUDE.md with the scan-pipeline seam; remove orphaned format_annotations#200
Merged
Conversation
…nnotations Close out the scan-pipeline unification (issue #117) with the docs-and-dead-glue cleanup that PRs A–F deferred. No behavior change. CLAUDE.md: document the two-layer scan seam in `git-tidy-core/src/scan.rs` (`parallel_classify` / `run_pipeline`, `RepoGroup<T>` / `ScanResult<T>`, `Classified`, `ScanOptions`) and the generic `Counts` newtype in `counts.rs`; extend the shared-output-helpers bullet with `write_json_flat` / `FlatJsonItems` / `IntoJsonItem` and `format_summary_buckets`; reword the parallel-fetch bullet now that fetch runs inside `run_pipeline`; alphabetize the core `src/` module list and add the six modules it was missing (caching, counts, date, filter, gix_ops, progress, scan); fix the corrupted Project Layout where a spurious second `git-lfs-tidy/` heading owned the repo-tidy subtree; and drop the deleted `*RepoGroup` / `RepoCounts` names from the per-tool `types.rs` comments. output.rs: delete `format_annotations`, the last `pub` helper the refactor orphaned (zero production callers; `format_table` now inlines the comma-join), along with its two unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR of the scan-pipeline unification (umbrella #117). Docs-only, plus one dead-code deletion. No behavior change.
CLAUDE.md
git-tidy-core/src/scan.rs: Layer 1parallel_classify(used directly by repo-, lfs-, and config-tidy) and Layer 2run_pipeline(the five uniform tools), with genericRepoGroup<T>/ScanResult<T>, theClassifiedtrait, andScanOptions.Countsnewtype (counts.rs) that replaced the per-tool*Countsstructs and thedefine_counts!macro.write_json_flat/FlatJsonItems/IntoJsonItemandformat_summary_buckets; dropformat_annotations(deleted below).run_pipelinewhenScanOptions.fetchis set.src/module list and add the six modules it was missing (caching, counts, date, filter, gix_ops, progress, scan); also fixes thefetch.rsalignment glitch.git-lfs-tidy/heading owned the repo-tidy subtree — repo-tidy now heads its own subtree, lfs-tidy appears once.*RepoGroup/RepoCountsnames from the per-tooltypes.rscomments; the liveLfsRepoGroup/ConfigRepoGroupare left intact.Code
format_annotationsfromgit-tidy-core/src/output.rs— the lastpubhelper the refactor orphaned (zero production callers;format_tablenow inlines the comma-join) — along with its two unit tests.Verification
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D clippy::all,cargo test --workspace, andcargo +1.93.0 check --workspace(MSRV) all pass. Core lib test count drops by 2 (the two deleted tests).Closes #117