Repository navigation
Release/v1.0.0 rc.2 - #27
Conversation
There was a problem hiding this comment.
Sorry @jake-dev-99, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes update log subscription cancellation in the CLI and change bundle generation to buffer output before atomically replacing the destination file. ChangesLog forwarder subscription
Atomic bundle output
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves PR #27 conflicts. PR #26 landed on main with the earlier versions of lib/entrypoint_cli.dart and native/shim/embed_bundle.py; rc.2 has since picked up two review-driven refinements on those files (inline cancel_subscriptions ignore moved to the .listen() site; atomic-write via BytesIO + os.replace in embed_bundle.py). Takes rc.2's side on both — the review fixes supersede what landed from #26. Also confirms py parse + dart analyze + dart test test/unit all clean after the resolution.
There was a problem hiding this comment.
Pull request overview
Release prep for v1.0.0-rc.2, focusing on correctness, CLI/Process transport reliability, and expanded regression coverage (goldens + CI matrix).
Changes:
- Bump package + platform wrapper versions to 1.0.0-rc.2 and harden release tooling (
sync_version,refresh_bundle, hook installer, bundle embed script). - Refactor Process-transport execution into shared helpers and improve logging behavior (move away from
Log.off, add root log forwarder for CLI). - Expand regression coverage: add/expand unit tests, add full-language golden matrix, and run integration tests on Ubuntu/macOS/Windows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tool/sync_version.dart | Hard-fail when listed version-sync targets are missing. |
| tool/smoke/ffi_noembed_smoke.dart | Make no-embed FFI smoke test portable across build layouts + OS dylib names. |
| tool/smoke/README.md | Document smoke scripts and which are wired into CI. |
| tool/refresh_bundle.dart | Add PATH/tooling preflights + safer repo-root detection and script presence checks. |
| tool/install_hooks.dart | Validate chmod success and exit with a clear error on failure. |
| tool/api_snapshot.txt | Update API snapshot for surface changes (Config/RendererOptions/etc.). |
| test/unit/type_infer_test.dart | Update import path for relocated type inference helper. |
| test/unit/temp_dir_sweeper_test.dart | Add unit coverage for temp-dir cleanup retry behavior. |
| test/unit/shell_test.dart | Update import for relocated shell formatting helper. |
| test/unit/renderer_options_test.dart | Remove Smithy options from the renderer-options coverage list. |
| test/unit/renderer_options_raw_test.dart | Add tests for RendererOptions.raw escape hatch. |
| test/unit/package_layout_test.dart | Add tests for package root + bundled quicktype exe resolution. |
| test/unit/file_resolver_test.dart | Add tests for new FileResolver glob/extension behaviors. |
| test/unit/config_test.dart | Expand config tests (strict mode, shape errors, defaults side effects, toString). |
| test/unit/bundle_source_test.dart | Update to new QuicktypeDart.bundleSource assignment API. |
| test/unit/backend_web_test.dart | Tighten assertions around default embedded bundle source. |
| test/unit/argv_test.dart | Add tests for renderer-options → argv encoding helper. |
| test/integration/goldens/user_typescript_just_types.ts.txt | New golden output for TS (just-types). |
| test/integration/goldens/user_swift_just_types.swift.txt | New golden output for Swift (just-types). |
| test/integration/goldens/user_scala.scala.txt | New golden output for Scala. |
| test/integration/goldens/user_sample.input.json | Shared integration input payload for goldens. |
| test/integration/goldens/user_rust.rs.txt | New golden output for Rust. |
| test/integration/goldens/user_ruby.rb.txt | New golden output for Ruby. |
| test/integration/goldens/user_python_just_types.py.txt | New golden output for Python (just-types). |
| test/integration/goldens/user_proptypes.js.txt | New golden output for PropTypes. |
| test/integration/goldens/user_php.php.txt | New golden output for PHP. |
| test/integration/goldens/user_objc.m.txt | New golden output for Objective-C. |
| test/integration/goldens/user_kotlin.kt.txt | New golden output for Kotlin. |
| test/integration/goldens/user_javascript.js.txt | New golden output for JavaScript. |
| test/integration/goldens/user_java_just_types.java.txt | New golden output for Java (just-types). |
| test/integration/goldens/user_haskell.hs.txt | New golden output for Haskell. |
| test/integration/goldens/user_go_just_types.go.txt | New golden output for Go (just-types). |
| test/integration/goldens/user_flow_just_types.js.txt | New golden output for Flow (just-types). |
| test/integration/goldens/user_elm.elm.txt | New golden output for Elm. |
| test/integration/goldens/user_elixir.ex.txt | New golden output for Elixir. |
| test/integration/goldens/user_csharp.cs.txt | New golden output for C#. |
| test/integration/goldens/user_c.c.txt | New golden output for C (cjson target). |
| test/integration/golden_test.dart | Rework golden harness: shared input, Process-pinned transport, error-shaped output guard. |
| pubspec.yaml | Bump Dart package version to rc.2. |
| native/shim/embed_bundle.py | Add clearer I/O errors + atomic write to avoid truncation/corruption. |
| macos/quicktype_dart.podspec | Bump CocoaPods version to rc.2. |
| lib/src/version.dart | Update in-library version constant to rc.2. |
| lib/src/utils/logging.dart | Remove old developer.log-based logging facade. |
| lib/src/utils/file_resolver.dart | Remove old resolver implementation (replaced by new package-private resolver). |
| lib/src/quicktype.dart | Use shared Process runner, improve stdout/stderr handling, update docs for Config changes. |
| lib/src/models/type_infer.dart | Fix import path after relocation within models/. |
| lib/src/models/type.dart | Fix TargetType.c argName (cjson), remove smithy, improve docs and exhaustive defaultPath switch. |
| lib/src/models/renderer_options.dart | Accept num in coercion, add RendererOptions.raw, add putOpt helper. |
| lib/src/models/options/options.dart | Restrict exports and remove smithy options export. |
| lib/src/models/options/lang_typescript.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_swift.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_smithy.dart | Remove Smithy renderer options type. |
| lib/src/models/options/lang_scala.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_rust.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_ruby.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_python.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_proptypes.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_php.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_objc.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_kotlin.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_javascript.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_java.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_haskell.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_go.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_flow.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_elm.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_elixir.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_dart.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_csharp.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_cpp.dart | Convert manual null checks to putOpt. |
| lib/src/models/options/lang_c.dart | Convert manual null checks to putOpt. |
| lib/src/models/enums.dart | Remove Smithy-specific enum. |
| lib/src/models/command.dart | Use shared renderer-options argv encoding helper. |
| lib/src/logging.dart | New package:logging-based facade (no off channel). |
| lib/src/internal/temp_dir_sweeper.dart | New reusable temp-dir cleanup/retry component (Windows-friendly). |
| lib/src/internal/shell.dart | New helper for human-readable command formatting. |
| lib/src/internal/quicktype_process.dart | New shared Process transport runner + executable resolution. |
| lib/src/internal/package_layout.dart | New package-root and bundled exe path resolution helpers. |
| lib/src/internal/argv.dart | New shared renderer-options → argv conversion helper. |
| lib/src/file_resolver.dart | New package-private glob/extension-aware file resolver. |
| lib/src/ffi/native_bundle_cache.dart | Rename SRI parsing helper to reflect nullable return contract. |
| lib/src/ffi/ffi_runtime.dart | Update messaging for new bundleSource assignment API. |
| lib/src/facade.dart | Replace setter API with bundleSource assignment; update docs. |
| lib/src/config.dart | Add strict load mode, improve parsing helpers, document defaults side effects, switch to new logging facade. |
| lib/src/bundle_source.dart | Update docs for new bundleSource assignment API. |
| lib/src/backend_web.dart | Harden script injection/wait logic, cancel subscriptions, improve error reporting. |
| lib/src/backend_io.dart | Use shared Process runner + argv helper; await file read before temp cleanup; encapsulate cleanup via TempDirSweeper. |
| lib/quicktype_dart.dart | Remove exports that leaked internals (Log, inferLangType). |
| lib/entrypoint_runner.dart | Use RendererOptions.raw and new logging facade. |
| lib/entrypoint_cli.dart | Forward package:logging root records to stdout/stderr; strict config parsing; improved version reporting. |
| ios/quicktype_dart.podspec | Bump CocoaPods version to rc.2. |
| android/build.gradle | Bump Android plugin version to rc.2. |
| CHANGELOG.md | Add detailed rc.2 changelog entry. |
| .github/workflows/ci.yml | Expand integration tests OS matrix, pin quicktype version, add ffi-noembed job. |
| .gitattributes | Force LF endings for goldens + API snapshot to prevent CRLF drift on Windows. |
Rebased release/v1.0.0-rc.2 onto current main (028d710, incl. Dependabot's esbuild 0.25→0.28 bump from #28). The prior branch carried ~30 commits whose content already landed on main via the #26 squash (c055cc0), so a literal replay would conflict against its own merged twins. Collapsed to the genuine net delta over current main: - lib/entrypoint_cli.dart: unawaited(_logSubscription?.cancel()) + relocate `// ignore: cancel_subscriptions` to the .listen() site (Copilot/CodeRabbit feedback). - native/shim/embed_bundle.py: buffer + atomic os.replace() write so a read failure can't truncate bundle_data.c. Both files byte-identical to the reviewed rc.2 versions; esbuild stays at main's 0.28.1 (Dependabot bump preserved, not reverted). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
54b612e to
2015aa6
Compare
Summary
Test plan
dart format --set-exit-if-changed lib test tool bin exampledart analyze --fatal-infos --fatal-warningsdart test test/unitdart test test/integration --tags=integration(if touching backend / generate path)dart run tool/sync_version.dartdart run tool/api_snapshot.dart(update via--write+ add CHANGELOG entry if the surface moved)Changelog
Breaking?
### Removed — breakingor### Changed — breakinginCHANGELOG.mdwith a migration snippet.🤖 Generated with Claude Code
Summary by CodeRabbit