General bug fixes and deprecation updates#24
Open
CarterDW wants to merge 5 commits into
Open
Conversation
…trapz as well as np.rowstack for np.trapezoid and np.vstack, as well as updated .toml, readme, and .yml to reflect new changes
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s Python/scientific-stack baseline by raising minimum dependency versions (NumPy/SciPy/Matplotlib), bumping the minimum supported Python version, and updating code to avoid NumPy APIs that are deprecated/removed in newer NumPy releases.
Changes:
- Raised minimum versions for
numpy,scipy, andmatplotlib, and increasedrequires-pythonto>=3.9. - Replaced deprecated NumPy APIs (
np.trapz,np.row_stack) with supported equivalents (np.trapezoid,np.vstack) across the codebase. - Updated examples and CI configuration to reflect the new baseline (with a noted CI version issue).
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Updates minimum dependency versions for end users installing via requirements file. |
| README.md | Removes outdated note about old NumPy compatibility. |
| pyproject.toml | Updates requires-python and project dependencies to match new minimum versions. |
| fastpt/utils/OV.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/utils/matter_power_spt.py | Removes legacy/commented trapz import reference. |
| fastpt/utils/kPol.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/utils/J_table.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/rsd/RSD.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_tt.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_ta.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_gb2.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_ctbias.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_ct.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/IA/IA_ABD.py | Replaces np.row_stack with np.vstack for NumPy 2.x compatibility. |
| fastpt/core/FPTHandler.py | Fixes docstring to reference save_instance() as the producer for load_instance(). |
| fastpt/core/FASTPT.py | Replaces np.trapz with np.trapezoid in sig4 computation. |
| fastpt/core/FASTPT_simple.py | Replaces np.trapz with np.trapezoid in bias integral computation. |
| fast_pt.egg-info/requires.txt | Updates generated metadata dependency versions (should not be version-controlled). |
| examples/IA_ABD_plot.py | Clarifies LaTeX dependency for usetex=True. |
| examples/hello_fastpt.py | Updates example to use save_instance() API. |
| examples/fastpt_example.py | Updates example to retrieve sig4 from one_loop_dd_bias return tuple. |
| examples/fastpt_example_nonlin_bias.py | Changes plotting behavior (now interactive), impacting headless execution. |
| .github/workflows/ci.yml | Updates Actions versions and dependency install steps; adds Python 3.14 (problematic). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@copilot re review |
I re-reviewed the current branch. I didn’t find any additional actionable changes from the prior review threads, so no new code changes were needed in this pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated numpy, scipy, matplotlip requirements, removed deprecated np.trapz as well as np.rowstack for np.trapezoid and np.vstack, as well as updated .toml, readme, and .yml to reflect new changes