chore: commit upstream KV namespace id in wrangler.jsonc#27
Merged
Conversation
Maintainer's account id is fine to commit — KV namespace ids are public per-account routing identifiers, not secrets. Forks still need to replace it with their own; README warning updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commits the upstream maintainer's KV namespace id (`9bf87d2cb1...`) into `wrangler.jsonc` so `npm run remote:deploy` works on this account without local edits or `--skip-worktree` tricks.
KV namespace ids are per-account public routing identifiers, not secrets — Cloudflare blocks any other account from using them. Forks still need to replace the value with their own id; the README warning is reworded to match.
Test plan