Skip to content

feat: add Traditional Chinese (zh-TW) language support#6

Merged
itsfatduck merged 1 commit into
itsfatduck:masterfrom
abc0922001:master
Mar 10, 2026
Merged

feat: add Traditional Chinese (zh-TW) language support#6
itsfatduck merged 1 commit into
itsfatduck:masterfrom
abc0922001:master

Conversation

@abc0922001

Copy link
Copy Markdown
Contributor
  • Add Translations.zh-TW.resx with fully localized UI strings
  • Add zh-TW to the language selector in SettingsViewModel

Description

This pull request adds complete Traditional Chinese (zh-TW) language support for users in Taiwan. It includes a fully translated .resx resource file adhering to local terminology and integrates the new language option into the application's settings menu.

Type of Change

  • 🐛 Bug fix (fix: - non-breaking change which fixes an issue)
  • ⚡ New Optimization/Tweak (feat: - adds a new system tweak or optimization rule)
  • ✨ New App Feature (feat: - adds UI, services, or core app functionality)
  • 🛠️ Refactoring (refactor: - code restructure that neither fixes a bug nor adds a feature)
  • 📝 Documentation update (docs:)
  • 🌐 Translation/Localization update (chore: or feat:)

Checklist

  • Commit Messages: My PR title and commit messages follow the Conventional Commits format (e.g., feat: add game mode optimization, fix: correct layout glitch).
  • Compilation & Tests: I have built the application (dotnet build optimizerDuck.slnx) and all tests pass (dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj).
  • Code Style: My C# code follows the project's naming conventions (PascalCase for classes/methods, camelCase for vars) and styling rules.
  • Localization (If adding UI text): I did NOT hardcode UI text. I have updated the .resx files located in the optimizerDuck/Resources/Languages/ directory.

For New Optimizations (Skip if irrelevant)

  • I inherited from BaseOptimization (or implemented IOptimization).
  • I included the [Optimization] attribute with a valid Guid formatted Id, a correct OptimizationRisk, and appropriate Tags.
  • I mapped the string keys properly so the Name and Description can be translated.

Screenshots or Video (if applicable)

image

Additional Context

No side effects expected. The translation adheres strictly to standard Taiwanese terminology.

- Add Translations.zh-TW.resx with fully localized UI strings
- Add zh-TW to the language selector in SettingsViewModel
@abc0922001
abc0922001 requested a review from itsfatduck as a code owner March 9, 2026 11:52
@itsfatduck itsfatduck self-assigned this Mar 9, 2026
@itsfatduck

Copy link
Copy Markdown
Owner

I will review this pull request as soon as possible, likely tomorrow (March 10, 2026 at 10:00 AM UTC+7), as I am currently busy with other work.

Thank you for your first contribution, and also for being the first to contribute a translation!

@itsfatduck itsfatduck left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thank you for your contribution!

@itsfatduck itsfatduck added enhancement New feature request or improvement to an existing feature. translation Issues or pull requests related to translating the application into additional languages. ui/ux Issues related to user interface or user experience improvements. labels Mar 10, 2026
@itsfatduck
itsfatduck merged commit 191bfb0 into itsfatduck:master Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature request or improvement to an existing feature. translation Issues or pull requests related to translating the application into additional languages. ui/ux Issues related to user interface or user experience improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants