Repository navigation
Fix late socket close handling in speech-to-text - #25
Merged
Merged
Conversation
The previous socket close handshake could land while the next startListening() was still awaiting the mic, tearing down the new session and opening its socket with an empty URL. ManagedSocket now reports closedByUser, and the hook ignores such closes while a session is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore late socket close events from previous sessions while a new session is starting, preventing disruptions in the speech-to-text functionality. Update version to 3.0.1 and document changes in the changelog.