Fix mobile sidebar closed state#31
Merged
Merged
Conversation
Collaborator
Author
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the mobile/tablet responsive sidebar CSS so the “closed” drawer state isn’t accidentally overridden by later desktop sidebar rules in main.css, and ensures the opened drawer layers correctly between the backdrop overlay and the fixed header.
Changes:
- Make the mobile/tablet
.book-sidebarclosed-state transform (translateX(-100%)) authoritative against later desktop rules by using!important. - Raise the mobile/tablet
.book-sidebarz-index to sit above the overlay (.book-sidebar-overlay) but below the fixed header (.book-header).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.csslater declares the desktop sidebar transformVerification
npm cinpm testgit diff --checkBUNDLE_PATH=/home/devuser/work/CodeX/booksB/.codex-local/tmp/issue-driven-bundle-path BUNDLE_APP_CONFIG=/home/devuser/work/CodeX/booksB/.codex-local/tmp/issue-driven-bundle-config npm run buildnode tools/pages-visual-check/run.mjs --registry .codex-local/issue-driven-built-registry.json --output .codex-local/issue168-issue-driven-local-visual --browsers chromium --viewports phone480,tablet,tablet820,laptop1024,desktop --onlyBooks issue-driven-work-book --maxPagesPerBook 2 --concurrency 1 --skipScreenshots --enforceFontSpec/and/chapters/chapter-01/at 480/768/820/1024/1280 widthsRelated: itdojp/it-engineer-knowledge-architecture#168